Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Screenshot & Screenshot history shortcut changing in MACOS #2098

Merged

Conversation

LHBosssss
Copy link
Contributor

From issue #1259 and my experience, I've enabled and tested this feature in my Hackintosh. So now you can change shortcut to take screenshot and show screenshot history (require restart flameshot).

  • Default key to take screenshot is "Cmd + Shift + X", screenshot history is "Option + Shift + X".
  • Added new translate text "Require restart flameshot".

From issue flameshot-org#1259 and my experience, I've fix and test this feature in my Hackintosh. So now you can change shortcut to take screenshot and show screenshot history (require restart flameshot).
- Default key to take screenshot is "Cmd + Shift + X", screenshot history is "Option + Shift + X".
- Added new translate text "Require restart flameshot".
Copy link
Contributor

@borgmanJeremy borgmanJeremy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also run clang-format after @veracioux gives comments.

Thanks for the contribution!!

src/config/setshortcutwidget.h Outdated Show resolved Hide resolved
src/config/setshortcutwidget.cpp Show resolved Hide resolved
@borgmanJeremy borgmanJeremy merged commit 2283b3e into flameshot-org:master Nov 21, 2021
@Idomo
Copy link

Idomo commented Nov 30, 2021

@borgmanJeremy May you release new patch version that includes this PR?
The current shortcut is so uncomfortable that it makes the whole app unusable for me... (I'm sure that it isn't just me)

Thanks.

@borgmanJeremy
Copy link
Contributor

No sorry, a back port release is an absolute nightmare and the main branch isn't ready for release.

@Idomo
Copy link

Idomo commented Nov 30, 2021

Got it.
Do you have an estimation for the next release?

@borgmanJeremy
Copy link
Contributor

Maybe sometime January? The last big thing to implement is the dbus pull request. However my free time in December will probably mostly be used on Advent of Code 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants